Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #485 +/- ##
==========================================
- Coverage 99.59% 99.59% -0.01%
==========================================
Files 51 51
Lines 997 995 -2
Branches 346 344 -2
==========================================
- Hits 993 991 -2
Misses 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR performs “misc patching” by upgrading core frontend/tooling dependencies (Storybook, Vite, TypeScript) and adjusting TypeScript configurations to accommodate updated compiler behavior across the monorepo.
Changes:
- Upgraded Storybook packages, Vite,
@vitejs/plugin-react, and TypeScript. - Updated root
tsconfig.jsonto suppress deprecation warnings for the new TypeScript baseline. - Tightened/standardized per-package TypeScript configs (e.g.,
rootDir, module resolution) and added explicit typings incomet-mcputilities to satisfy stricter typechecking.
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.json | Adds ignoreDeprecations to align with the upgraded TypeScript version. |
| packages/comet-uswds/tsconfig.json | Sets rootDir to ./src for more explicit project structure under TS updates. |
| packages/comet-extras/tsconfig.json | Sets rootDir to ./src for consistent compilation boundaries. |
| packages/comet-data-viz/tsconfig.json | Sets rootDir to ./src for consistent compilation boundaries. |
| packages/comet-mcp/tsconfig.json | Updates module resolution strategy, adds Node types, and excludes dist from compilation inputs. |
| packages/comet-mcp/src/utils.ts | Adds explicit callback parameter typings to satisfy stricter TS inference/implicit-any behavior. |
| package.json | Bumps Storybook/Vite/TypeScript and related tooling versions for patching/security. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bapplejax
left a comment
bapplejax
left a comment
There was a problem hiding this comment.
pulled locally and works wtih all commands!
Description
Related Issue
N/A
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):